Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Frontend: Rename Service Autostart #5736

Merged
merged 9 commits into from
Apr 25, 2024
Merged

🎨 Frontend: Rename Service Autostart #5736

merged 9 commits into from
Apr 25, 2024

Conversation

odeimaiz
Copy link
Member

@odeimaiz odeimaiz commented Apr 25, 2024 •
edited
Loading

What do these changes do?

  • Rename: Disable Services Auto Start -> Autostart services

Bonus:

  • Show No personal Credit Account found or No shared Credit Accounts found in wallets list
  • Reload button on Usage table

AutoStart

Related issue/s

related to (only tackles the renaming) ITISFoundation/osparc-issues#1042

How to test

Dev-ops checklist

@odeimaiz odeimaiz added this to the Enchanted Odyssey milestone Apr 25, 2024
@odeimaiz odeimaiz self-assigned this Apr 25, 2024
@odeimaiz odeimaiz changed the title remove fake.dev WIP Frontend: Service autostart UI improvements Apr 25, 2024
@odeimaiz odeimaiz changed the title WIP Frontend: Service autostart UI improvements WIP 🎨 Frontend: Service autostart UI improvements Apr 25, 2024
@odeimaiz odeimaiz added t:enhancement Improvement or request on an existing feature a:frontend issue affecting the front-end (area group) labels Apr 25, 2024
@odeimaiz odeimaiz changed the title WIP 🎨 Frontend: Service autostart UI improvements 🎨 Frontend: Rename Service Autostart Apr 25, 2024
@odeimaiz odeimaiz marked this pull request as ready for review April 25, 2024 14:32
@odeimaiz odeimaiz enabled auto-merge (squash) April 25, 2024 14:34
matusdrobuliak66
matusdrobuliak66 approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@matusdrobuliak66 matusdrobuliak66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 General note: For me, it would make sense if the default behavior were that they do not start automatically. Only if a user explicitly wants it, can he change it.

@matusdrobuliak66
Copy link
Contributor

And thanks for the usage view changes! :)

elisabettai
elisabettai approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@elisabettai elisabettai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, what autostart does is clearer now. 😉

I'll show it to Team Black and discuss keeping the "check" button (instead of toggle).
Toggle would look nicer maybe, and clear if we add color when it is ON.

ignapas
ignapas approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@ignapas ignapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@odeimaiz odeimaiz merged commit eb62c89 into ITISFoundation:master Apr 25, 2024
50 checks passed
This was referenced Apr 26, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@sanderegg sanderegg sanderegg approved these changes

@elisabettai elisabettai elisabettai approved these changes

@ignapas ignapas ignapas approved these changes

@jsaq007 jsaq007 Awaiting requested review from jsaq007 jsaq007 is a code owner

@pcrespov pcrespov Awaiting requested review from pcrespov

Assignees

@odeimaiz odeimaiz

Labels
a:frontend issue affecting the front-end (area group) t:enhancement Improvement or request on an existing feature
Projects
None yet
Milestone
Enchanted Odyssey
Development

Successfully merging this pull request may close these issues.
5 participants
@odeimaiz @matusdrobuliak66 @ignapas @elisabettai @sanderegg